replace "os.getlogin()" with "pwd.getpwuid(os.getuid())" #33
Conversation
Hello everyone, I am setting up Open IO in Docker. In the process, I notice that using `os.getlogin()` does not work if the user that executes the program is not logged in via the `login` command. More generally, it seems like `getlogin()` is not too reliable and `getpwuid(getuid())` seems to be a better way to do the same thing: http://stackoverflow.com/questions/4785126/getlogin-c-function-returns-null-and-error-no-such-file-or-directory Best regards, Conrad
jfsmig
added a commit
that referenced
this issue
Jun 1, 2015
replace "os.getlogin()" with "pwd.getpwuid(os.getuid())"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hello everyone,
I am setting up Open IO in Docker. In the process, I notice that using
os.getlogin()does not work if the user that executes the program is not logged in via thelogincommand. More generally, it seems likegetlogin()is not too reliable andgetpwuid(getuid())seems to be a better way to do the same thing: http://stackoverflow.com/questions/4785126/getlogin-c-function-returns-null-and-error-no-such-file-or-directoryDoes this change make sense ? Does
getlogindo somethinggetpwuid(getuid())doesn't do ?Best regards,
Conrad